Add warning messages for uncommon user define configurations

src/ui/components/UserDefinesAdvisor/index.tsx

@@ -0,0 +1,68 @@
+import React, { FunctionComponent } from 'react';
+import { Alert, makeStyles } from '@material-ui/core';
+import { DeviceOptionsFormData } from '../DeviceOptionsForm';
+import { UserDefineKey, UserDefinesMode } from '../../gql/generated/types';
+
+interface UserDefinesAdvisorProps {
+  deviceOptionsFormData: DeviceOptionsFormData;
+}
+
+const useStyles = makeStyles((theme) => ({
+  container: {
+    marginBottom: theme.spacing(2),
+  },
+}));
+
+const UserDefinesAdvisor: FunctionComponent<UserDefinesAdvisorProps> = ({
+  deviceOptionsFormData,
+}) => {
+  const styles = useStyles();
+  const messages: string[] = [];
+  if (deviceOptionsFormData.userDefinesMode === UserDefinesMode.UserInterface) {
+    const isUserDefine = (
+      key: UserDefineKey,
+      enabledValue: boolean
+    ): boolean => {
+      const value = deviceOptionsFormData.userDefineOptions.find(
+        (item) => item.key === key
+      );
+      if (value?.enabled === enabledValue) {
+        return true;
+      }
+      return false;
+    };
+
+    if (isUserDefine(UserDefineKey.UART_INVERTED, false)) {
+      messages.push(
+        'Disabling UART_INVERTED is uncommon. Please make sure that your transmitter supports that.'
+      );
+    }
+
+    if (isUserDefine(UserDefineKey.FEATURE_OPENTX_SYNC, false)) {
+      messages.push(
+        'Disabling FEATURE_OPENTX_SYNC is uncommon. Keeping it disabled will prevent the ExpressLRS LUA script from communicating with the TX module properly.'
+      );
+    }
+
+    if (isUserDefine(UserDefineKey.NO_SYNC_ON_ARM, true)) {
+      messages.push(
+        'NO_SYNC_ON_ARM is an advanced performance option. Make sure to read the documentation on how it works.'
+      );
+    }
+  }
+  return (
+    <div>
+      {messages.length > 0 && (
+        <div className={styles.container}>
+          {messages.map((message, idx) => (
+            <Alert key={idx} severity="warning">
+              {message}
+            </Alert>
+          ))}
+        </div>
+      )}
+    </div>
+  );
+};
+
+export default UserDefinesAdvisor;

src/ui/components/UserDefinesList/index.tsx

@@ -133,7 +133,6 @@ const UserDefinesList: FunctionComponent<UserDefinesListProps> = (props) => {
                 </ListItem>
               </>
             )}
-
             {item.type === UserDefineKind.Enum && item.enabled && (
               <ListItem className={styles.complimentaryItem}>
                 <Omnibox

src/ui/views/ConfiguratorView/index.tsx

@@ -48,6 +48,7 @@ import UserDefinesValidator from './UserDefinesValidator';
 import ApplicationStorage from '../../storage';
 import persistDeviceOptions from '../../storage/commands/persistDeviceOptions';
 import mergeWithDeviceOptionsFromStorage from '../../storage/commands/mergeWithDeviceOptionsFromStorage';
+import UserDefinesAdvisor from '../../components/UserDefinesAdvisor';
 
 export const validateFirmwareVersionData = (
   data: FirmwareVersionDataInput
@@ -461,6 +462,10 @@ const ConfiguratorView: FunctionComponent = () => {
               <CardTitle icon={<SettingsIcon />} title="Actions" />
               <Divider />
               <CardContent>
+                <UserDefinesAdvisor
+                  deviceOptionsFormData={deviceOptionsFormData}
+                />
+
                 <Button
                   className={styles.button}
                   size="large"