-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace covid19-data json for Django API endpoint #231
Conversation
@tokland I did notice there was a bug changing the page size. The request was made two times because first, it made the request on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just a very minor comment, trivial to fix.
app/assets/javascripts/covid19/src/webapp/components/structures-table/useStructuresTable.ts
Outdated
Show resolved
Hide resolved
Add new uniprot-chain mappings endpoint
📌 References
📝 Implementation
This PR aims to no longer need the famous
covid19-data.json
JSON file to load Covid19 Structural Hub, making the entries table to load instantly on the Main app (Ruby); and to no longer rely on manual updates of the file. For now, some requests are still a bit slow, but we should be focusing on the next iteration (I suggest creating a new PR for the optimization changes https://app.clickup.com/t/86942378n, and some other subtasks remaining)./pdbentry
.env
" "
because elasticsearch's default behavior is to exact match.StructuresTable.tsx
touseHooks
UI changes
Enter
or click on the search icon is requiredsnackbar
Skeleton
on the first load to reduce the user's waiting sensationCircularProgress
next to the filter button, cancel option appears if page size more than 25LinearProgress
at the bottom pagination🔥 Testing
Add
REACT_APP_BWS_HOST
to your.env.local
, for now, you can usepercy.uk.to:8000
. We will be able to use rinchen host after machine upgrades 👾💯