Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracker type problems when updating to new d2-api version that supports DHIS2 2.41 #318

Merged

Conversation

anagperal
Copy link
Contributor

@anagperal anagperal commented Jan 24, 2025

📌 References

📝 Implementation

  • 1st step for decoupling d2-api tracker types from domain: create tracker entities in the domain. The next step will be map tracker entities to entity types (each repository with its own entity) in the data repositories and replace the tracker types created in domain
  • add required ouMode in some d2 tracker endpoint calls

📹 Screenshots/Screen capture

test build:

Screencast.from.2025-01-29.14-24-10.webm

AMR - Fungal
AMR_fungal_test

AMR Individual RIS:
AMR-Indiv_RIS_tes

AMR aggregated:

test_AMR_agg.webm

EGASP:
EGASP_test

AMC Product:
AMC-SUBSTANCE-CALCULATED-AFG-Populated_from_product.xlsx
AMC-PRODUCT-CALCULATED-AFG-Populated.xlsx

AMC Substance:
AMC-SUBSTANCE-CALCULATED-AFG-Populated_from_subs.xlsx

🔥 Testing

  1. Docker:
    docker.eyeseetea.com/amrcont/dhis2-data:2.41-widp-cont-dev

  2. Execute to install new d2-api version:

nvm use
yarn install

Files for testing:

AFG-2024-Indiv.csv
EGASP-PHL-TEMPLATE_2023.xlsx
AFG_2023_DS5_AMR_AGG_SAMPLE.txt
AMR-Fun-AFG-2022_CorrectCombo.txt
AFG_2023_AMR_AGG_RIS.txt
AMC-Substance Level Data-AFG-TEMPLATE_2023.xlsx
AMC-Product Level Data-AFG-TEMPLATE_2024.xlsx

@anagperal anagperal requested a review from 9sneha-n January 24, 2025 11:51
@ifoche
Copy link
Member

ifoche commented Jan 24, 2025

Task linked: CU-8697kr6qt DHIS Upgrade Testing Support

@anagperal anagperal marked this pull request as ready for review January 29, 2025 13:25
@anagperal anagperal changed the title Fix tracker type problems when updating to new d2-api version Fix tracker type problems when updating to new d2-api version that supports DHIS2 2.41 Jan 29, 2025
Copy link
Contributor

@9sneha-n 9sneha-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anagperal

@bhavananarayanan bhavananarayanan merged commit 78423cf into development Feb 4, 2025
@bhavananarayanan bhavananarayanan deleted the fix/new-tracker-types-domain-coupled-d2-api branch February 4, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants