Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public profile backend #33

Merged
merged 6 commits into from
Aug 5, 2018
Merged

Public profile backend #33

merged 6 commits into from
Aug 5, 2018

Conversation

ashatat
Copy link
Contributor

@ashatat ashatat commented Aug 4, 2018 •
edited
Loading

Related to #19

Summary

  • create the back-end API for the Profile component
    • to get the publicProfile data send a 'GET' request to /api/profile?id=<userId>
    • to update the publicProfile data send a 'PUT' request to /api/profile?id=<userId>

@ashatat ashatat requested a review from MahmoudMH August 4, 2018 19:47
MahmoudMH
MahmoudMH requested changes Aug 5, 2018
View reviewed changes
backend/controllers/profile.js Outdated
const { id } = req.query;
getProfileData(id, (err, result) => {
if (err) {
console.log('getProfile', err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete console.log

@ashatat
Copy link
Contributor Author

ashatat commented Aug 5, 2018

@MahmoudMH
already removed the console.log, please review the code again

@MahmoudMH MahmoudMH merged commit 7368a79 into master Aug 5, 2018
@emanKhaledh emanKhaledh deleted the public-profile-backend branch August 5, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahmoudMH MahmoudMH MahmoudMH approved these changes

@emanKhaledh emanKhaledh Awaiting requested review from emanKhaledh

@ahmadmshatat ahmadmshatat Awaiting requested review from ahmadmshatat

@ishak52 ishak52 Awaiting requested review from ishak52

Assignees
No one assigned
Labels
exist-conflicts request-changes under-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashatat @MahmoudMH @ishak52