Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name type for opt spec #333

Closed
wants to merge 3 commits into from
Closed

Conversation

RonHildebrandt
Copy link

was required to describe "partial" nametypes in Nomad (e.g. beam_TYPE)

@RonHildebrandt RonHildebrandt changed the base branch from main to fairmat February 21, 2025 11:53
@RonHildebrandt
Copy link
Author

RonHildebrandt commented Feb 25, 2025

Closed as this will be included in another PR.

@RonHildebrandt
Copy link
Author

RonHildebrandt commented Feb 26, 2025

Reopend this PR again, as the inclusion of these changes in another PR were not possible right now. This is due the dev_tools, which are not up to date yet to include the nameType=partial. This needs to be updated to pass the CI/CD.

Only 1 CI/CD test present, as this has to be rebased?

@lukaspie
Copy link
Collaborator

lukaspie commented Mar 4, 2025

After rebasing, no changes are left because I fixed the nameType in #332 already. Closing here.

@lukaspie lukaspie closed this Mar 4, 2025
@lukaspie lukaspie deleted the nameType_for_opt_spec branch March 4, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants