v01-00

v01-00

• 2017-11-16 Yorgos Voutsinas (PR#30)

  • LumiCalReco: Correcting the units when reading the thickness of the LumiCal layer
  • LumiCalReco: Correcting position reconstruction of the ZCell

• 2017-11-17 Andre Sailer (PR#29)

  • LumiCalClusterer: Assign hits to the created cluster, fixes #8
    • Instead of the simulated hits collection a Digitized Hits collection for the LumiCal should be passed. If a SimCalorimterHit collection is passed dummy digitization is done and the CalorimeterHit collection is written out, controlled by Parameter LumiCal_Hits with default value LumiCalHits

• 2017-11-20 Andre Sailer (PR#31)

  • LumiCalReco: base all calculations on calibrated hits, allows "external" calibration
  • LumiCalReco: correct the cluster position calculation for optimal theta resolutions, ensure consistency between theta calculation and cluster position (x,y,z). Theta calculation for theta in the rootOutput was correct, the theta for SLCIO output is now much better reconstructed.
  • LumiCalReco: add RCellOffset to calculate radial cell coordinate for DD4hep segmentation, automatically derived from segmentation (affected the ROOT output for Theta)
  • LumiCalReco: re-factoring for weight calculations, cleanup, debug outputs

• 2017-11-22 Andre Sailer (PR#32)

  • LumiCalClusterer: scale weights by RMin/RCell to reduce polar angle bias
  • LumiCalClusterer: fix azimuthal angle offset when taking segmentation from DD4hep (actually no longer used, all (I hope...) position calculations are now based on the position of the hits)
  • LumiCalClusterer: Refactor ClusterClass, now using MCInfo and LCCluster to hold information, remove duplicated cluster position calculations

• 2017-11-27 Marko Petric (PR#34)

  • Add missing #include <functional> for std::placeholders

• 2018-01-19 Andre Sailer (PR#35)

  • Add automatic test for LumiCal reconstruction, some re-factoring to run tests without instantiating geometry
  • Fix bug for cluster at negative Z, where cluster at 0/180 degrees might have been split into 2
  • Optionally add cling-tidy and fix some issues it pointed out
  • Fix a bug in the finding of the max neighbouring pad that was introduced long time ago in the initial import and clean-up
  • Fix bugs in the calculation of the position at the LumiCal front used for MCParticle <-> cluster matching

• 2018-01-24 Andre Sailer (PR#36)

  • Add linking of clusters and hits, fixes #9 , one can use CalorimeterHit or SimCalorimeterHit collections
  • Added the possibility to run the BeamCal reconstruction on the LumiCal, which gives more reasonable results in the presence of background and multiple clusters.
  • New parameters for BeamCalClusterReco:
    • MaxPadDistance: limit the distance between primary tower and other towers for clustering),
    • LogWeightingConstant: if larger 0 uses logarithmic weighting for calculating shower position, like the LumiCal reco,
    • DetectorStartingLayerID: The BeamCal driver starts layers at 1 , the LumiCal driver at 0
    • DetectorName: the name of the detector in the compactXML file this processor instance is for
  • New background method: Empty, allows running without (pair) background file
  • Fixes for position calculation of cluster in BeamCalClusterReco

• 2018-01-27 Andre Sailer (PR#38)

  • Fix DrawBeamCalFromDD4hep processor, fixes #37 , removed superfluous and incompatible geometry checks

• 2018-01-29 StrahinjaLukic (PR#39)

  • Optional feature was added to DrawBeamCalFromDD4hep to draw hit energy density per unit area rather than hit energy. This option is steerable via the new parameter DrawDensities
  • The z-axis range is calculated automatically in the polar segmentation plot of DrawBeamCalFromDD4hep.
  • A simple legend is drawn in the polar segmentation plot of DrawBeamCalFromDD4hep to indicate the dynamic range of the z-axis.
  • Minor style changes were made to the polar segmentation plot of DrawBeamCalFromDD4hep.

• 2018-02-01 Frank Gaede (PR#41)

  • add missing header cmath to TestUtilities.hh for gcc49 and gcc54

• 2018-02-02 Andre Sailer (PR#43)

  • BeamCalReco: fill subclusterEnergy to given ID via the ProcessorParameter: SubClusterEnergyID
  • BeamCalReco/LumiCalReco: set charge to 0 so to not confuse the RecoMCTruth linker

• 2018-02-02 Andre Sailer (PR#42)

  • Cleanup includes with "Include what you use", remove unused ones, explicitly add all used ones
  • Remove some pragma warnings for implemented features
  • Replace NULL with nullptr
  • Adapt to changes proposed in iLCSoft/LCIO#35, use LCIO namespaces

• 2018-02-06 Marko Petric (PR#44)

  • Include DD4hepUnits.h from DD4hep and not from DDParsers (which was renamed to Evaluator)

• 2018-03-08 Andre Sailer (PR#46)

  • ReadBeamCal: The processor can now also be used to read backgrounds for the LumiCal detector. New processor Parameters DetectorName and DetectorStartingLayerID

• 2018-03-16 Andre Sailer (PR#50)

  • BeamCalClusterReco: fix problem when using CalorimeterHit collection as input
    • add optional parameter ReadoutName to be set in that case
  • BeamCalClusterReco: fix setting of CalorimeterHit collection flags , fixes #49 , where the cluster was only having nullptrs when the collection was written out
  • BeamCalClusterReco: only add hits to cluster if they don't come from background
  • BeamCalClusterReco: Pregenerated background, remove explicit gear dependency

• 2018-03-27 Andre Sailer (PR#52)

  • BeamCalClusterReco: add tree for efficiency post processing, and efficiency objects to get fake rates for different fake cluster energy ranges
  • BeamCalClusterReco: Protect against crash when input collection is empty, fixes #51
  • BeamCalClusterReco PrintThisEvent option: make compatible with LumiCal detector
  • ReadBeamCal: fix for using LumiCal (only half the LumiCal was properly read, pads with sector<0 were rejected)

• 2018-03-28 Andre Sailer (PR#54)

  • LumiCalReco: fix setting of flags for CalorimeterHit collection (ID1, LONG) instead of copying from SimCalorimeterHit input collection, whose bits mean different things