Skip to content

Commit

Permalink
open trade work
Browse files Browse the repository at this point in the history
  • Loading branch information
elowy01 committed Jan 26, 2024
1 parent fb63238 commit f281189
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 1 addition & 1 deletion trading_journal/open_trade.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging

from datetime import datetime

from trading_journal.trade import Trade
Expand Down Expand Up @@ -189,4 +190,3 @@ def run(self) -> None:
)
self.outcome = "n.a."
self.finalise_trade(cl=cl)

8 changes: 1 addition & 7 deletions trading_journal/trade.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from __future__ import division
from abc import ABC, abstractmethod
import logging
import pdb

Expand All @@ -24,7 +23,7 @@
t_logger = logging.getLogger(__name__)
t_logger.setLevel(logging.INFO)

class Trade(ABC):
class Trade():
"""This is an abstrace class represents a Trade.
Class variables:
Expand Down Expand Up @@ -199,11 +198,6 @@ def get_SLdiff(self) -> float:

return number_pips

@abstractmethod
def run(self, expires: int = 2) -> None:
"""Run the trade until conclusion from a start datetime."""
pass

def __str__(self):
sb = []
for key in self.__dict__:
Expand Down

0 comments on commit f281189

Please sign in to comment.