Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline support #666

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adityacp
Copy link
Contributor

@adityacp adityacp commented Mar 18, 2020

- Add a new field in lesson model to add relative offline video path
- Add a vue app to provide offline interface
- Create a zip file to download
@codecov-io
Copy link

codecov-io commented Mar 19, 2020

Codecov Report

Merging #666 into master will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   81.50%   80.54%   -0.96%     
==========================================
  Files          36       36              
  Lines        5158     5110      -48     
  Branches      837      782      -55     
==========================================
- Hits         4204     4116      -88     
- Misses        641      697      +56     
+ Partials      313      297      -16     
Impacted Files Coverage Δ
yaksh/forms.py 83.95% <100.00%> (-0.14%) ⬇️
yaksh/models.py 89.61% <100.00%> (-0.12%) ⬇️
yaksh/views.py 71.60% <100.00%> (+0.20%) ⬆️
yaksh/r_code_evaluator.py 0.00% <0.00%> (-79.42%) ⬇️
yaksh/middleware/user_time_zone.py 90.00% <0.00%> (-2.86%) ⬇️
yaksh/templatetags/custom_filters.py 90.16% <0.00%> (-1.64%) ⬇️
grades/views.py 93.93% <0.00%> (-0.35%) ⬇️
grades/models.py 94.73% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4802a89...90ac2f7. Read the comment docs.

@adityacp adityacp force-pushed the download_course_with_vue branch from 51c6e73 to 89b33b6 Compare March 19, 2020 08:47
@CruiseDevice
Copy link
Member

I think the offline app in this PR does not have support for int, str, float type questions. I have already created a PR for this in my own repo, but not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants