Merge pull request #771 from antoinevg/antoinevg/fix-pullmode

Add support for PULLMODE=NONE to lpf generation
FPGAwars · Oct 7, 2024 · d46fc82 · d46fc82
2 parents 63c6c71 + e6705c8
commit d46fc82
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/app/scripts/services/compiler.js b/app/scripts/services/compiler.js
@@ -956,9 +956,7 @@ angular.module('icestudio')
 
               //-- Get the pullmode property of the physical pin (its id is pin.value)
               let pullmode = common.selectedBoard.pinout.find(x => x.value === value).pullmode;
-              pullmode = (typeof pullmode === 'undefined') ? 'NONE' : pullmode;
-
-              if (pullmode === 'UP' || pullmode === 'DOWN') {
+              if (pullmode === 'UP' || pullmode === 'DOWN'  || pullmode === 'NONE') {
                 code += 'PULLMODE=' + pullmode;
               }
               code += ' ;\n\n';
@@ -978,9 +976,7 @@ angular.module('icestudio')
 
             //-- Get the pullmode property of the physical pin (its id is pin.value)
             let pullmode = common.selectedBoard.pinout.find(x => x.value === value).pullmode;
-            pullmode = (typeof pullmode === 'undefined') ? 'NONE' : pullmode;
-
-            if (pullmode === 'UP' || pullmode === 'DOWN') {
+            if (pullmode === 'UP' || pullmode === 'DOWN' || pullmode === 'NONE') {
               code += 'PULLMODE=' + pullmode;
             }
             code += ' ;\n\n';