Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Reef Scoring and Dealgaefy Set Desired Level Commands #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WasteOfTheOcean
Copy link
Contributor

No description provided.

Copy link
Contributor

@wegnergit wegnergit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a singleton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get away from prefixing class attributes/fields with m_ (reefPositions)?
Did we want to remove "New" and/or "getNew" (maybe createSetScorre...) from method names (getNewSetScoreLevelCommand)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants