Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved attacks list to separate file #470

Closed
wants to merge 0 commits into from

Conversation

silvanathecat
Copy link
Contributor

this makes it easier to add and remove them. i also added a meme one about the chain this year just because i needed to change the file for the commit to work.

ignore my last pr, the attacks.py file wasn't there.

@silvanathecat
Copy link
Contributor Author

haven't intrinsically tested it, but it should be fine... as long as i included all the required files...

@silvanathecat silvanathecat marked this pull request as draft March 21, 2024 23:24
@devyntk
Copy link
Member

devyntk commented Mar 21, 2024

Im not sure how necessary this is.. I could see a much better argument for making the attacks a static variable at the top of the file, but a separate file for a ~200 line file to get smaller seems like overkill to me. If we're insistent on separating this out, it should at least be a static file (json or toml is my preference) that's not in source for easy customization.

@silvanathecat
Copy link
Contributor Author

silvanathecat commented Mar 22, 2024

will rewrite for json (seems to be the project standard) on my lunch... ive also been thinking about possibly adding a command to add attacks and a better system for damage, will probably work on that... tomorrow? busy tonight after class, but could do it late.

gonna keep it as a draft until i do that though, and once the checks go through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants