Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Z3 version check again #3700

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Fixed Z3 version check again #3700

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d575a6a
Reverted removal of Z3 version check fix which breaks when Z3 binarie…
Johanmyst Jan 29, 2025
dde3d94
Z3: add a comment about version checking
mtzguido Jan 30, 2025
cd4a84d
Merge branch 'master' into master
mtzguido Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/smtencoding/FStarC.SMTEncoding.Z3.fst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,12 @@ let check_z3version (p:proc) : unit =
);
_already_warned_solver_mismatch := true
);
let ver_found : string = BU.trim_string (getinfo "version") in
(* Note: Z3 can either output a "clean" version like 4.13.4 or something like
"4.13.4 - build hashcode 6d3cfb63daa9afdd7d6d6b4d2f2fb84bd7324571" depending
on how it was built. Hence we split by "-" and take the first component to
ignore the hashcode. See https://github.com/FStarLang/FStar/pull/3700 for
more details. *)
let ver_found : string = BU.trim_string (List.hd (BU.split (getinfo "version") "-")) in
let ver_conf : string = BU.trim_string (Options.z3_version ()) in
if ver_conf <> ver_found && not (!_already_warned_version_mismatch) then (
let open FStarC.Errors in
Expand Down
Loading