Dev #759
Merged
Dev #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated QuestFile#getOrCreateTeamData(Player) in favour of getTeamData(Player player), which returns an Optional. It's possible for this to empty if FTB Teams hasn't init'd the player data yet, which can happen when new players join the server. FTBTeam/FTB-Mods-Issues#1383
…figured Allows panning while left-clicking over a background image
Can happen if a quest has multiple optional tasks where completing one task completes the quest. FTBTeam/FTB-Mods-Issues#1390
Just use a simple string argument type for quest object IDs QuestObjectArgument depends on the server quest file being loaded, which breaks using ftbquests commands in MC functions; these are parsed much sooner than the quest file can be loaded. FTBTeam/FTB-Mods-Issues#1422
Caveat: only saves translations this client knows about (i.e. that the server has sync'd to it). Saving every known translation is planned for a future version.
Rewards the player with one of every entry from the given reward table, regardless of weighting. FTBTeam/FTB-Mods-Issues#32
Lock icon controllable via both a quest file setting and player preferences Enabled by default FTBTeam/FTB-Mods-Issues#1448
Necessary for translations to work for them in the new 1.21 translations system. Also a few other small fixes & improvements to the reward table editor in general. FTBTeam/FTB-Mods-Issues#1442
Useful to extract items with custom components (e.g. FFS Smart Filters) if you don't have a copy of the item to hand.
MichaelHillcox
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few changes here!