Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bullets effects code in ev_hldm.cpp #235

Closed
wants to merge 1 commit into from

Conversation

malortie
Copy link
Contributor

@nekonomicon
Copy link
Member

All good, but any compiler will optimize this code and ignore switch.

@malortie
Copy link
Contributor Author

Understood, but this is to simplify code.

I created separate PRs for the other changes, so that you may choose to merge or close.

@nekonomicon
Copy link
Member

but this is to simplify code

I didn't see any reasons to remove empty switch-cases here.
It's already code style changes, not just refactoring.
It will be better to leave such code as is for changes in the future.

@malortie malortie deleted the simplify-bullets-effects-code branch January 4, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants