-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Resources Article #167
Open
Manchick0
wants to merge
6
commits into
FabricMC:main
Choose a base branch
from
Manchick0:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a comprehensive guide to custom resources, covering client and server-side data. Implemented a `JsonDataLoader` example and updated sidebars, including their translations.
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
requested changes
Aug 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good, just a minor nitpick.
Introduced a new EmptyDataLoader class extending JsonDataLoader, intended solely for guidance in the 'custom resources' documentation.
Deleted EmptyDataLoader.java and introduced new Book and Fruit data loader classes for improved data handling. Updated documentation to reflect the changes, including new examples and clarifications on resource types and Codec usage.
Any updates? |
its-miroma
added
new-content
A new page or set of pages
stage:verification
This should be verified
stage:cleanup
This should be cleaned up
and removed
stage:cleanup
This should be cleaned up
labels
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a comprehensive guide to custom resources, covering client and server-side data.