Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking Guide #249

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Networking Guide #249

wants to merge 8 commits into from

Conversation

dicedpixels
Copy link
Contributor

Ports Networking.

Differences:

  • Actual working item, Lightning Tater.
  • Along with S2C, a C2S example is also included.

Note: PR is marked as draft till docs are updated to 1.21.4. Feel free to review till then.

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for nimble-elf-d9d491 failed.

Name Link
🔨 Latest commit 2140ab1
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/678a8c36b5ae4600081a04e9

@IMB11 IMB11 added new-content A new page or set of pages stage:verification This should be verified labels Dec 31, 2024
develop/networking.md Outdated Show resolved Hide resolved
develop/networking.md Outdated Show resolved Hide resolved
develop/networking.md Outdated Show resolved Hide resolved
develop/networking.md Outdated Show resolved Hide resolved
@IMB11
Copy link
Member

IMB11 commented Jan 15, 2025

Hi! The documentation has been updated to version 1.21.4. Please rebase your PR and update your code to align with the latest version.

Alternatively, you can create a new branch based on the latest commit from the FabricMC:main branch, copy over your changes from the old dicedpixels:networking branch, update it, and open a new PR - this approach is often simpler than dealing with complex git commands if you're not the best git wrangler.

Once you've completed the updates and are confident everything is ready, feel free to unmark this as a draft. Thanks again for your contribution!

- remove dedicated data generator
- add lightning tater item model generator to the shared pack
- fix offset line numbers
- fix broken link in damage types doc
- add more info about `PlayerLookup` and adjust the code
- limt the `UseItemCallback` to the logical client
- attempted to improve the c2s section to align with review comments
@its-miroma its-miroma added stage:expansion This should be expanded and removed stage:verification This should be verified labels Jan 18, 2025
@its-miroma its-miroma mentioned this pull request Jan 29, 2025
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages stage:expansion This should be expanded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants