Updated gradle wrapper version to support Java 16. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liach
reviewed
May 3, 2021
| @@ -397,18 +384,46 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO | |||
| List<ClassInstance> ret = new ArrayList<ClassInstance>(); | |||
|
|
|||
| if (file.toString().endsWith(".class")) { | |||
| ClassInstance res = analyze(isInput, tags, srcPath, Files.readAllBytes(file)); | |||
| ClassInstance res = analyze(isInput, tags, srcPath, OptionalInt.empty(), Files.readAllBytes(file)); // FIXME? | |||
There was a problem hiding this comment.
No need for fixme; mrj mechanism doesn't exist for flat directory
|
|
||
| boolean isMrj = false; | ||
| if(file.getFileName().toString().endsWith(".jar")){ | ||
| System.out.println("jar"); |
There was a problem hiding this comment.
I recall java util's jar file api has support for getting version-aware jar entries. If there is existing api, we should use those than build our own since our own is vulnerable to ignoring impl/api requirements
modmuss50
reviewed
May 3, 2021
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-bin.zip | |||
There was a problem hiding this comment.
You can also update the github workflows to use java 16 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.