Allow running the mongo test suite against mongomock #1083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
force-pushed
the
mongomock
branch
6 times, most recently
from
c79472a
to
838c941
Compare
ArchLinux and maybe other Linux distributions have interest in testing their package of the project, in an environment where MongoDB isn’t available. Support for that environment is provided on a best-effort basis. If this patch ends up being more trouble than it’s worth, please revert it. Otherwise, let’s be helpful to others. :)
> If setUpClass() fails, meaning that tearDownClass() is not called, then any cleanup functions added will still be called.
francoisfreitag
force-pushed
the
mongomock
branch
from
838c941
to
ef733fe
Compare
|
Merged as 819acce, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests in a mock environment would be helpful to packagers for Arch Linux, and maybe others. They do not have access to a running MongoDB instance in the package build environment but would still like to run smoke tests against the package.
The tests against
mongomockhave been included in the regular test suite to keep verifying that environment.Tests that require a MongoDB instance can be skipped by setting the environment variable
MONGO_USE_MOCK=1.Support is being provided on a best-effort basis, to help downstream packagers. FactoryBoy could remove support for this feature if it ends up being an issue, as the usage is fairly niche. Requiring a MongoDB instance to run the Mongo test suite does not seem unreasonable.
Closes #1081