Export types per PEP 561 #1103
Open
Export types per PEP 561 #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic typing support was added recently, exposing return types for `create()` and `build()`: FactoryBoy#1059 However, because this package does not expose these types, consumers of `factory-boy` cannot leverage the annotations! Let's ensure that the package exports its types. It's okay for only a subset of methods to be typed! (In other words, it's still compliant with PEP 561 to have partial coverage).
DavidCain
force-pushed
the
dcain-py-typed
branch
from
082cb59
to
f3e50d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic typing support was added recently, exposing return types for
create()andbuild():#1059
However, because this package does not expose these types, consumers of
factory-boycannot leverage the annotations!Let's ensure that the package exports its types. It's okay for only a
subset of methods to be typed! (In other words, it's still compliant
with PEP 561 to have partial coverage).