-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sonic's base-fee computation algorithm #296
Add Sonic's base-fee computation algorithm #296
Conversation
e3825cc
to
bb4adec
Compare
d7d20e1
to
5d89d11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the comments are definitely helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just small nitpick about new introduced type.
6f99355
6f99355
to
778903c
Compare
dcde650
to
67e6008
Compare
This PR introduces Sonic's base-fee adjustment algorithm. The algorithm is a generalization of the fee market price algorithm described in EIP-1559 supporting a variable block-time period.
The maximum increase and decrease is limited to approximately ±12.5% per 15 seconds, analog to Ethereum's implementation.