Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test covering the restart of a node #303

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

HerbertJordan
Copy link
Collaborator

This PR adds the ability to add tests including the restart of a network node.

Recently, issues have been reported that the restart of a node with local state fails during it startup phase. To address such issues, a new integration test including the restarting of nodes got added. One of the reported issue -- for the node failing to be able to re-load its local transaction pool data -- could be reproduced and fixed as part of this PR.

Copy link
Collaborator

@jenikd jenikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad that it reporoduced the issue

@HerbertJordan HerbertJordan merged commit 4a1871d into develop Nov 14, 2024
2 checks passed
@HerbertJordan HerbertJordan deleted the herbert/add_node_restart_test branch November 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants