Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for tx order verification #305

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Integration test for tx order verification #305

merged 1 commit into from
Nov 15, 2024

Conversation

cabrador
Copy link
Collaborator

@cabrador cabrador commented Nov 14, 2024 •
edited
Loading

This PR adds an integration test which checks the transaction order consistency within blocks.
This :

  1. Spawns M number of accounts
  2. Spawns N number of txs for each account
  3. Verifies correct order of transaction for each account
  4. Repeats this for X number of blocks

@cabrador cabrador marked this pull request as draft November 14, 2024 16:28
@cabrador cabrador changed the title C/integration test tx order [WIP] Integration test tx order Nov 15, 2024
@cabrador cabrador changed the title [WIP] Integration test tx order [WIP] Integration test for tx order verification Nov 15, 2024
@cabrador cabrador force-pushed the c/integration-test-tx-order branch 2 times, most recently from b04b427 to f2c7364 Compare November 15, 2024 14:40
@cabrador cabrador marked this pull request as ready for review November 15, 2024 14:42
@cabrador cabrador changed the title [WIP] Integration test for tx order verification Integration test for tx order verification Nov 15, 2024
HerbertJordan
HerbertJordan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@cabrador cabrador merged commit 18df2cb into develop Nov 15, 2024
2 checks passed
@cabrador cabrador deleted the c/integration-test-tx-order branch November 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerbertJordan HerbertJordan HerbertJordan approved these changes

@jmpike jmpike Awaiting requested review from jmpike jmpike is a code owner

@thaarok thaarok Awaiting requested review from thaarok thaarok is a code owner

@jenikd jenikd Awaiting requested review from jenikd jenikd is a code owner

@LuisPH3 LuisPH3 Awaiting requested review from LuisPH3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabrador @HerbertJordan