Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adopt common .NET conventions #475

Merged
merged 1 commit into from
Nov 27, 2023
Merged

refactor: adopt common .NET conventions #475

merged 1 commit into from
Nov 27, 2023

Conversation

JoaoRodriguesGithub
Copy link
Contributor

@JoaoRodriguesGithub JoaoRodriguesGithub commented Nov 21, 2023 •
edited
Loading

Description

This refactor aims the following:

  • Have all usings outside the namespace;
  • Replace private variables (this) to use the _
  • Move tests folder to root
  • Move sln file to root

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@brmagadutra brmagadutra force-pushed the refactor branch 3 times, most recently from b93ea85 to 1847246 Compare November 23, 2023 12:10
@JoaoRodriguesGithub JoaoRodriguesGithub force-pushed the refactor branch 3 times, most recently from 32742e7 to 1dad165 Compare November 23, 2023 17:14
@JoaoRodriguesGithub JoaoRodriguesGithub changed the title Draft refactor: release 3.0 refactor: release 3.0 Nov 24, 2023
@JoaoRodriguesGithub JoaoRodriguesGithub marked this pull request as ready for review November 24, 2023 08:54
joelfoliveira
joelfoliveira requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@joelfoliveira joelfoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes that need to be addressed before merging

@joelfoliveira joelfoliveira changed the title refactor: release 3.0 refactor: adopt common conventions by .NET Nov 24, 2023
@JoaoRodriguesGithub
refactor: adopt common .NET conventions
4c1dfec 
This refactor aims the following
- Have all usings outside namespace
- Replace private variables this to use _
- Move tests folder to root
- Move sln file to root
@JoaoRodriguesGithub JoaoRodriguesGithub changed the title refactor: adopt common conventions by .NET refactor: adopt common .NET conventions Nov 27, 2023
@joelfoliveira joelfoliveira merged commit 9142a81 into release/3.0 Nov 27, 2023
@joelfoliveira joelfoliveira deleted the refactor branch November 27, 2023 09:59
@gsferreira gsferreira mentioned this pull request Dec 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelfoliveira joelfoliveira joelfoliveira approved these changes

@simaoribeiro simaoribeiro simaoribeiro approved these changes

@brmagadutra brmagadutra brmagadutra approved these changes

@gsferreira gsferreira Awaiting requested review from gsferreira

@filipeesch filipeesch Awaiting requested review from filipeesch

@ailtonguitar ailtonguitar Awaiting requested review from ailtonguitar

@ruiqbarbosa ruiqbarbosa Awaiting requested review from ruiqbarbosa

@erik-catalao erik-catalao Awaiting requested review from erik-catalao

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoaoRodriguesGithub @joelfoliveira @simaoribeiro @brmagadutra