Fail on null creator properties when deserializing #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Would be happy to merge this. One practical thing first, then; unless we already have gotten it, we need the Contributor License Agreement (CLA) before merging the first contribution: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and usually developers print it, fill & sign, scan and email to |
|
Thanks, glad to know that I was managed to help. And I have sent the agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing work in this discussion: #990
The commit implements new deserialization feature
FAIL_ON_NULL_CREATOR_PROPERTIES. The feature is tested.I might have missed something, will be happy for a feedback!