Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set StreamReadCapability.EXACT_FLOATS=true #307

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

htmldoug
Copy link
Contributor

@htmldoug htmldoug commented Dec 20, 2021

This gets the ball rolling setting the StreamReadCapability.EXACT_FLOATS flag from FasterXML/jackson-core#733 (issue: FasterXML/jackson-core#730).

  • Smile
  • CBOR
  • Avro
  • Protobuf
  • Ion

I'm pausing here to take feedback (on both PRs) before proceeding with the last three formats (which I'm slightly less familiar with anyway).

@cowtowncoder
Copy link
Member

As per my other note, let's split things so that we'll

  1. First add new read capability, overrides for formats, basic tests to verify backend exposes values as exposed
  2. Then add functionality that uses capability detection (as there are a few details to figure out, as per my notes on jackson-core issue)

@cowtowncoder cowtowncoder merged commit 4c92b34 into FasterXML:2.14 Jan 16, 2022
@cowtowncoder
Copy link
Member

ok, merged: I can take care of the other backends too; added Avro, test.

@cowtowncoder
Copy link
Member

Clarification: I'll take care of adding capability setting, introspection, but if you have spare cycles for testing actual behavior that'd be great. If not, we'll get those eventually. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants