-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 헤더 레이아웃 작업 #14
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ab95d0c
feat: 헤더 레이아웃 생성
wo-o29 1c8845c
feat: 레이아웃 설정
wo-o29 8a487fd
Merge branch 'develop' into feature/layout
wo-o29 3bf29c9
refactor: 레이아웃 main 태그 제거
wo-o29 6ac16dd
Merge branch 'feature/layout' of https://github.com/FestiBook/fronten…
wo-o29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { ReactNode } from "react"; | ||
|
||
interface HeaderLayoutProps { | ||
children: ReactNode; | ||
} | ||
|
||
function HeaderLayout({ children }: HeaderLayoutProps) { | ||
return ( | ||
<> | ||
<header>추후 헤더 완성되면 만들어진 헤더 사용 예정 </header> | ||
{children} | ||
</> | ||
); | ||
} | ||
|
||
export default HeaderLayout; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component가 페이지 기본 구조대로 렌더링 되는것(어떤 레이아웃이든지 상관없이 페이지 컴포넌트만 렌더링) 되는 방식에서 getLayout을 통한 렌더링으로 바꿔주셨네요 !! 유지보수까지 고려한 코드 LGTM입니다 !! 👍