[feat] 여행 가이드북 디자인, API 연결(무한 스크롤) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
yura0302
approved these changes
Aug 30, 2024
src/apis/axios.ts
Outdated
| @@ -1,5 +1,12 @@ | |||
| import axios from "axios"; | |||
|
|
|||
| export const guideBookInstance = axios.create({ | |||
There was a problem hiding this comment.
인스턴스를 여러개 설정하면 중복코드로 메모리 누수가 발생하거나 설정이 중복될 수 있다고 생각합니다 ..!
가독성은 여러개의 인스턴스를 설정하는게 좋지만, 저희가 방대하게 많은 api를 콜하는게 아니라 토이프로젝트 수준이기 때문에 단일 인스턴스로 매개변수로 BASE_URL을 넘기는게 나을 것 같습니다 ! 👍
There was a problem hiding this comment.
넵 좋습니다 그러면 기본 인스턴스에 저희 백엔드 API를 BaseUrl로 설정하고 외부 API를 사용하는 경우에는 setInstance() 함수를 호출해서 매개변수로 BASE_URL 넘겨서 사용하고, 추가적으로 인터셉터 해야하는 인스턴스가 생기면 그 인스턴스만 따로 빼주면 될 것 같습니다!
|
|
||
| export const GUIDE_BOOK_KEYS = { | ||
| all: ["guide-book"] as const, | ||
| lists: () => [...GUIDE_BOOK_KEYS.all, "list"] as const, |
There was a problem hiding this comment.
가이드북키 상수로 설정해주신거 좋은것같습니다 ! 👍👍👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 이슈 번호
🏁 작업 내용(필수)
💬 리뷰 요구 사항(선택)
BASE_URL넘겨주는 방식으로 갈까요?!📸 스크린샷 or 동작 영상(선택)
2024-08-07.10.53.10.mov