Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support summary message error reactions #140

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Support summary message error reactions #140

merged 5 commits into from
Feb 10, 2025

Conversation

namoscato
Copy link
Collaborator

@namoscato namoscato commented Feb 5, 2025 •
edited
Loading

See Reroute successful deploy notifications for additional context.

Summary

  • Add SlackClient.maybeAddErrorReaction method
  • Deepen SlackClient to handle missing scope errors
  • Split getEnv into getRequiredEnv / getEnv methods
  • Introduce isCodedPlatformError utility method, abstracted from isMissingScopeError
  • Move dateFromTs to named module

Testing

Tested E2E in a testing repository / channel, i.e.

Screenshot 2025-02-05 at 4 34 13 PM

@namoscato namoscato marked this pull request as ready for review February 5, 2025 23:26
@namoscato namoscato mentioned this pull request Feb 5, 2025
Closed
@namoscato namoscato merged commit dde431b into main Feb 10, 2025
5 checks passed
@namoscato namoscato deleted the namoscato/sc-30451/reroute-successful-deploy-notifications branch February 10, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blacksmoke16 Blacksmoke16 Blacksmoke16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namoscato @Blacksmoke16