This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for sending requests to thrift when the message must go over HTTP instead of the default thrift transport.
Another flag should be made to allow to set the path however I'm curious on thoughts around how this should be done if upstream is interested in supporting it. If so we could have a --http_client_path flag and doing that defaults to / and turns on the http client so we don't need two flags to support the http client.
Tested locally as well using