Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev sort[SiliconFlow] #222

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dev sort[SiliconFlow] #222

wants to merge 4 commits into from

Conversation

MARD1NO
Copy link
Collaborator

@MARD1NO MARD1NO commented Sep 23, 2024

PR Category

Operator

Type of Change

New Feature

Description

Add SOrt Kernel

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

image

when sorted element is too large, bitomic merge cause register spilling

@MARD1NO MARD1NO marked this pull request as ready for review October 9, 2024 09:08
zhzhcookie
zhzhcookie approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@zhzhcookie zhzhcookie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isin calls large size torch.sort, pytest test_special_ops.py -s -m isin will cause much time with this sort op implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhcookie zhzhcookie zhzhcookie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MARD1NO @zhzhcookie