-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add lru cache #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # requirements-dev.txt # requirements.txt
gagantrivedi
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with one minor comment (and lint fixes)
4730286
to
49458db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LRU caching to the edge proxy which allows users to configure caching on the flags and identities endpoints.
When the edge proxy receives an updated environment document it clears the cache to ensure that updated values are received.
New settings:
Current concerns: by clearing the cache when we receive an updated environment, we are risking a thundering herd issue in a platform with sustained high load.
An alternative approach (one which can be seen in the first commit of this PR) is to use a
ttl_cache
instead of one which is completely evicted when an environment update occurs.I tend to think that the latest approach is better and there are unlikely to be scenarios where the platform is under such significant load that there will be a thundering herd issue, but it's definitely something that should be considered.
In terms of the implementation, it definitely needs some tweaks and some test coverage. I am most concerned about the tight coupling, but I wasn't able to find an easy solution. I will come back to it in the morning...
Finally, I have tested this manually and, for a project that has 300 features, I ran a load test (albeit one that requests the flags for the same identity over and over again) and got an improvement from 137rps to 2600rps for a single edge proxy docker container.