ci: Fail release workflow if no new releases were published #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously tried to create a release by running the release workflow after manually creating a tag/release: https://github.com/Flagsmith/flagsmith-charts/actions/runs/13566028719/job/37919249460
This did not work because chart-releaser-action always creates the tag/release, with no option to change this behaviour. However, the release workflow still succeeded, which is confusing.
This PR makes it so that the release workflow fails if no releases were published, which should make this situation easier to understand and manually correct if it happens again.
A better solution would be to fully implement release-please, which I understand means we'd need to implement a more manual release pipeline like this random repository: https://github.com/Mailu/helm-charts/blob/master/.github/workflows/publish-chart.yaml
This PR is not tested - it can be tested by YOLO-merging and trying to run the release workflow again, which should fail.Tested using act with my personal GitHub token: