feat: Identity overrides in local evaluation mode #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
matthewelwell
and removed request for
a team
khvn26
force-pushed
the
feat/identity-overrides-local-eval
branch
from
db231b4 to
43d2a71
Compare
client.go
Outdated
| @@ -276,15 +277,28 @@ func (c *Client) UpdateEnvironment(ctx context.Context) error { | |||
| return errors.New(e["detail"]) | |||
| } | |||
| c.environment.Store(&env) | |||
| ids := make(map[string]identities.IdentityModel) | |||
There was a problem hiding this comment.
I don't love the variable naming here. I think by ids we're referring to identities, but at first glance, I was expecting just a numeric id for example.
khvn26
force-pushed
the
feat/identity-overrides-local-eval
branch
2 times, most recently
from
29e3152 to
043cc5c
Compare
khvn26
force-pushed
the
feat/identity-overrides-local-eval
branch
from
043cc5c to
704d365
Compare
khvn26
force-pushed
the
feat/identity-overrides-local-eval
branch
from
f9863ce to
f561275
Compare
matthewelwell
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112.
Contributes to Flagsmith/flagsmith#3132.
Merge #122 first!