Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for httpNodeAuth #341

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add support for httpNodeAuth #341

merged 1 commit into from
Feb 10, 2025

Conversation

knolleary
Copy link
Member

Part of FlowFuse/flowfuse#5014

Description

This PR adds support for FF User authentication for the HTTP Node/Dashboard routes.

  • It adds the FF Auth plugin. For now, its a copy/paste of the plugin from the nr-launcher repo - was easier than trying to repackage.
  • It maintains support for setting httpNodeAuth in the device.yml file - that takes precedence over whatever is configured via the platform
  • Bumps device agent to v3.1.0 - this is the feature used on the platform-side PR to detect if these options can be applied to the device.
  • Platform-side PR: Add support for httpNodeAuth settings on devices flowfuse#5068

@knolleary
Copy link
Member Author

@Steve-Mcl I've tagged you for a review here. We can discuss details on Monday morning, but would appreciate if you're able to spare an hour on this.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but not merging. Needs to be a coordinated release with merging of

FlowFuse/flowfuse#5068

@knolleary
Copy link
Member Author

We can safely merge this one - it is inert until the user enables FF Auth via #5068

@knolleary knolleary merged commit 0eca17f into main Feb 10, 2025
4 checks passed
@knolleary knolleary deleted the 5014-support-ff-auth branch February 10, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants