First pass at file api for k8s #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Steve-Mcl This and the docker one, please review but don't merge |
|
localfs for comparison FlowFuse/driver-localfs#144 |
Steve-Mcl
reviewed
Aug 22, 2024
| @@ -23,6 +23,7 @@ | |||
| "dependencies": { | |||
| "@aws-sdk/client-efs": "^3.600.0", | |||
| "@kubernetes/client-node": "^0.18.1", | |||
| "form-data": "^4.0.0", | |||
There was a problem hiding this comment.
Is this package supported on Node versions < 18?
Because form-data is like 4y old, uses depreciated utils.isArray and FormData is now a part of Node 18.
There was a problem hiding this comment.
OK, we need to review this across all the static asset code, as Nick has used it in the localfs driver
There was a problem hiding this comment.
@Steve-Mcl I'm going to leave this for now as it works
There was a problem hiding this comment.
ok, understand. Should probably raise an issue to mop this up later.
Steve-Mcl
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the driver interface to FlowFuse/nr-launcher#273
Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel