Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The e2e offboarding test is randomly failing #5019

Closed
cstns opened this issue Jan 15, 2025 · 1 comment · Fixed by #5023
Closed

The e2e offboarding test is randomly failing #5019

cstns opened this issue Jan 15, 2025 · 1 comment · Fixed by #5023
Assignees
@cstns
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:XS - 1 Sizing estimation point

Comments

@cstns
Copy link
Contributor

cstns commented Jan 15, 2025

Current Behavior

The offboarding e2e test is sometimes failing in GH actions due to it redirecting to an external domain

Expected Behavior

the test should not fail, we could redirect to another reliable endpoint

Steps To Reproduce

failing example:
https://github.com/FlowFuse/flowfuse/actions/runs/12793056774/job/35664971345?pr=5017

Environment

  • FlowFuse version: 2.12.0
  • Node.js version: N/A
  • npm version: N/A
  • Platform/OS: N/A
  • Browser: N/A

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate
@cstns cstns added bug Something isn't working needs-triage Needs looking at to decide what to do labels Jan 15, 2025
@cstns cstns self-assigned this Jan 15, 2025
@cstns cstns added area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point labels Jan 15, 2025
@knolleary
Copy link
Member

knolleary commented Jan 15, 2025 •
edited
Loading

Have included a (potential) fix for this in 99f83f9 as the associated PR had hit it.

@cstns cstns closed this as completed Jan 16, 2025
knolleary added a commit that referenced this issue Jan 16, 2025
@knolleary
Change external domain used in offboarding test to be more reliable
84b9f65 
Fixes #5019
@knolleary knolleary mentioned this issue Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cstns cstns

Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:XS - 1 Sizing estimation point
Projects
☁️ Product Planning
Status: Closed / Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change external domain used in offboarding test to be more reliable FlowFuse/flowfuse
2 participants
@knolleary @cstns