Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change external domain used in offboarding test to be more reliable #5023

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

knolleary
Copy link
Member

Fixes #5019

The offboarding test that verifies the user gets redirected to the configured URL is a bit flaky as it redirects to Google which sometimes returns something unexpected.

This changes the test to redirect to nodered.org and far more predictable.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (e1e344c) to head (84b9f65).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5023   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files         329      329           
  Lines       15478    15478           
  Branches     3574     3574           
=======================================
  Hits        12136    12136           
  Misses       3342     3342           
Flag Coverage Δ
backend 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 46cdfcc into main Jan 16, 2025
20 checks passed
@knolleary knolleary deleted the fix-logout-refer-test branch January 16, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The e2e offboarding test is randomly failing
2 participants