Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copy button to broker client username #4701

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

hardillb
Copy link
Contributor

part of #4685

Description

Add a copy button to the broker client username to make it easier to use

before:

image

after:

image

Might need CSS tweaking a little bit more

Related Issue(s)

#4685

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (be80c5b) to head (96033b3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4701   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files         311      311           
  Lines       14670    14670           
  Branches     3355     3355           
=======================================
  Hits        11551    11551           
  Misses       3119     3119           
Flag Coverage Δ
backend 78.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 3f48e3f into main Oct 25, 2024
14 checks passed
@hardillb hardillb deleted the copy-broker-client-username branch October 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants