Add a team link component to simplify routing #4942
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…nent-to-simplify-routing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## app-routes-follow-up #4942 +/- ##
=====================================================
Coverage 78.31% 78.31%
=====================================================
Files 326 326
Lines 15387 15387
Branches 3536 3536
=====================================================
Hits 12051 12051
Misses 3336 3336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-simplify-routing
|
@cstns is this ready for review? Noticed you've assigned no reviewer...? |
|
Need a couple of moments to refresh my memory |
|
#4891 would need to be merged in first so we can keep it simple, and I'd need to sort some conflicts on that one first. I'll mark it as a draft untill then |
…-simplify-routing # Conflicts: # frontend/src/components/DevicesBrowser.vue # frontend/src/pages/device/index.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a ff-team-link component that would simplify routes parametrization
Related Issue(s)
part of #4836
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel