Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party broker #5015

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

3rd party broker #5015

wants to merge 5 commits into from

Conversation

hardillb
Copy link
Contributor

part of #4969

Description

Adds APIs for provisioning 3rd Party MQTT Broker credentials for a team

  • /api/v1/teams/:teamId/broker/credentials GET/POST
  • /api/v1/teams/:teamId/broker/brokerId GET/PUT/DELETE
  • /api/v1/teams/:teamId/broker/:brokerId/credentials GET

Related Issue(s)

#4969

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 29.16667% with 51 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (69a00e9) to head (b27196d).
Report is 168 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/teamBroker/index.js 21.95% 32 Missing ⚠️
forge/db/models/BrokerCredentials.js 40.00% 9 Missing ⚠️
forge/db/views/BrokerCredentials.js 10.00% 9 Missing ⚠️
...igrations/20250109-01-EE-3rd-party-broker-creds.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5015      +/-   ##
==========================================
- Coverage   78.44%   78.16%   -0.28%     
==========================================
  Files         325      332       +7     
  Lines       15353    15550     +197     
  Branches     3529     3578      +49     
==========================================
+ Hits        12043    12154     +111     
- Misses       3310     3396      +86     
Flag Coverage Δ
backend 78.16% <29.16%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor Author

Team delete needs to also remove all 3rd party broker creds and shut down any mqtt-schema-agents that might be running.

container driver needs to look at DB on startup and restart any missing mqtt-schema-agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant