Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-saml to 5 #5037

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Update node-saml to 5 #5037

merged 2 commits into from
Jan 20, 2025

Conversation

knolleary
Copy link
Member

Replaces #4734

The bump to node-saml@5 includes a breaking change on its options object - cert is now idpCert.

This PR updates to node-saml@5 and maps the old property to the new name. Tested locally against azure SSO.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (efc15ce) to head (88cdfe2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5037   +/-   ##
=======================================
  Coverage   78.40%   78.41%           
=======================================
  Files         329      329           
  Lines       15478    15480    +2     
  Branches     3574     3574           
=======================================
+ Hits        12136    12138    +2     
  Misses       3342     3342           
Flag Coverage Δ
backend 78.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor

Tested with keycloak, appears to work as expected

@hardillb hardillb merged commit b85e9fd into main Jan 20, 2025
20 checks passed
@hardillb hardillb deleted the update-node-saml branch January 20, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants