Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add config option for team broker hostname #525

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jan 9, 2025

Description

Allow team broker hostname to be set in the flowforge.yml

Defaults to broker.[forge.domain]

(Also set EMQX config option)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production (NA as default matches)

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from ppawlowski January 9, 2025 09:54
@hardillb hardillb self-assigned this Jan 9, 2025
@ppawlowski
Copy link
Contributor

Since it's a team broker, I believe we should continue the transition we started when the feature was introduced and add a new config under broker object instead of forge.broker.teamBroker.

@hardillb
Copy link
Contributor Author

hardillb commented Jan 9, 2025

But we already have forge.broker.hostname which would be confusing

@ppawlowski
Copy link
Contributor

Right, but with this change we will end up with team broker configuration scattered in two places which will also introduce confusion.
From my perspective previous approach was clear - team broker values defined in broker object, old broker values defined in forge.broker object.

@hardillb
Copy link
Contributor Author

hardillb commented Jan 9, 2025

ahh, sorry I miss understood.

@hardillb
Copy link
Contributor Author

hardillb commented Jan 9, 2025

Have a look now

@ppawlowski
Copy link
Contributor

Looks good. Feel free to merge when suitable.

@hardillb hardillb merged commit b29f26e into main Jan 9, 2025
8 checks passed
@hardillb hardillb deleted the team-broker-hostname branch January 9, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants