Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow File Storage database name to be customised #536

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds a possibility to specify custom database name used by the File Storage service.
Additionally, it removes hardcoded database username from the initialisation script.

Related Issue(s)

#305

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb February 2, 2025 11:05
@ppawlowski
Copy link
Contributor Author

The failure in the lint workflow is acceptable due to the known error with the chart linting tool not using the new values file.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppawlowski approved, my only question about this is if we are going this route should we also allow different host, port, username & password as well?

@ppawlowski
Copy link
Contributor Author

@ppawlowski approved, my only question about this is if we are going this route should we also allow different host, port, username & password as well?

For file-storage configuration - we already allow for such approach.

For the initialisation script - it is scoped to run only against local postgres so only credentials can be changed - this is something we cover as well.

@hardillb
Copy link
Contributor

hardillb commented Feb 3, 2025

Sorry, I meant running the ff-context db on a totally separate postgresql instance.

But don't worry about that now

@ppawlowski ppawlowski merged commit 536621c into main Feb 4, 2025
7 of 8 checks passed
@ppawlowski ppawlowski deleted the fix-secrets-in-scripts branch February 4, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants