UI Switch - More reliable onChange handler & accompanying E2E Test #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@click
event handler which watched the click event, then invertted the current value and emitted it. It would appear, for some reason that the@click
handler sometimes ran after the underlying Vue tick had computed, and sometimes before.value
to the switch, which guarantees we see an accurate value in the event handler, even on reload.Related Issue(s)
Closes #457
Checklist