FEATURE: check if properties of node are valid #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few checks are run against the properties of the node 1. It is checked, that a node only has properties set, that were declared in the NodeType 2. In case the property is a select-box, it is checked, that the current value is a valid option of the select-box 3. It is made sure is that a property value is never null for the reason: In case that due to a condition in the nodeTemplate `null` is assigned to a node property, it will override the defaultValue. This is a problem, as setting `null` might not be possible via the Neos UI and the Fusion rendering is most likely not going to handle this edge case. So we assume this must have been a mistake. A cleaner, but also more difficult way would be to actually assert that the type matches
mhsdesign
commented
May 31, 2023
| * @var FeedbackCollection | ||
| * @Flow\Inject | ||
| */ | ||
| protected $feedbackCollection; |
There was a problem hiding this comment.
this is hacky as hell i know ^^
mhsdesign
commented
May 31, 2023
|
Included in #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few checks are run against the properties of the node
It is checked, that a node only has properties set, that were declared in the NodeType
In case the property is a select-box, it is checked, that the current value is a valid option of the select-box
It is made sure is that a property value is never null for the reason: In case that due to a condition in the nodeTemplate
nullis assigned to a node property, it will override the defaultValue. This is a problem, as settingnullmight not be possible via the Neos UI and the Fusion rendering is most likely not going to handle this edge case. So we assume this must have been a mistake. A cleaner, but also more difficult way would be to actually assert that the type matches