Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/1905 #1906

Closed
wants to merge 1 commit into from
Closed

Bugfix/1905 #1906

wants to merge 1 commit into from

Conversation

Oktopuce
Copy link
Contributor

No description provided.

@Oktopuce Oktopuce force-pushed the bugfix/1905 branch 2 times, most recently from e1ce46d to 089b7e7 Compare April 23, 2024 16:30
@NamelessCoder
Copy link
Member

I've made the decision to reject this, based on the argument I gave in #1905 (comment). It is undesirable to have this API silently suppress the warnings about unreadable page records - suggested alternative is to use try (in templates, v:try) and add a fallback case if you need to use ViewHelpers or API where you are unsure if the page exists and need to tolerate cases where it doesn't. Just like you'd need to in any of your own code when using the core's RootLineUtility.

@NamelessCoder NamelessCoder mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oktopuce @NamelessCoder