Merge pull request #104 from Foblex/103-bug-typeerror-cannot-read-pro…

…perties-of-undefined-reading-fgroupscontainer 103 bug typeerror cannot read properties of undefined reading fgroupscontainer
Foblex · Jan 10, 2025 · 3e7bb3a · 3e7bb3a
2 parents 3bce99c + a9856e3
commit 3e7bb3a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 36 deletions.
diff --git a/angular.json b/angular.json
@@ -131,39 +131,6 @@
           }
         }
       }
-    },
-    "m-render": {
-      "projectType": "library",
-      "root": "projects/m-render",
-      "sourceRoot": "projects/m-render/src",
-      "prefix": "lib",
-      "architect": {
-        "build": {
-          "builder": "@angular-devkit/build-angular:ng-packagr",
-          "options": {
-            "project": "projects/m-render/ng-package.json"
-          },
-          "configurations": {
-            "production": {
-              "tsConfig": "projects/m-render/tsconfig.lib.prod.json"
-            },
-            "development": {
-              "tsConfig": "projects/m-render/tsconfig.lib.json"
-            }
-          },
-          "defaultConfiguration": "production"
-        },
-        "test": {
-          "builder": "@angular-devkit/build-angular:karma",
-          "options": {
-            "tsConfig": "projects/m-render/tsconfig.spec.json",
-            "polyfills": [
-              "zone.js",
-              "zone.js/testing"
-            ]
-          }
-        }
-      }
     }
   }
 }
diff --git a/projects/f-flow/package.json b/projects/f-flow/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@foblex/flow",
-  "version": "17.0.2",
+  "version": "17.0.4",
   "description": "An Angular library designed to simplify the creation and manipulation of dynamic flow. Provides components for flows, nodes, and connections, automating node manipulation and inter-node connections.",
   "main": "index.js",
   "types": "index.d.ts",

diff --git a/projects/f-flow/src/domain/sort-item-layers/sort-item-layers.execution.ts b/projects/f-flow/src/domain/sort-item-layers/sort-item-layers.execution.ts
@@ -16,8 +16,11 @@ export class SortItemLayersExecution implements IExecution<SortItemLayersRequest
   }
 
   public handle(request: SortItemLayersRequest): void {
-    this.fMediator.send(new SortItemsByParentRequest(this.fComponentsStore.fCanvas!.fGroupsContainer.nativeElement));
+    if(!this.fComponentsStore.fCanvas) {
+      return;
+    }
+    this.fMediator.send(new SortItemsByParentRequest(this.fComponentsStore.fCanvas.fGroupsContainer.nativeElement));
     this.fMediator.send(new SortNodeLayersRequest());
-    this.fMediator.send(new SortItemsByParentRequest(this.fComponentsStore.fCanvas!.fNodesContainer.nativeElement));
+    this.fMediator.send(new SortItemsByParentRequest(this.fComponentsStore.fCanvas.fNodesContainer.nativeElement));
   }
 }
diff --git a/...ap-calculate-svg-scale-and-view-box/minimap-calculate-svg-scale-and-view-box.execution.ts b/...ap-calculate-svg-scale-and-view-box/minimap-calculate-svg-scale-and-view-box.execution.ts
@@ -26,6 +26,10 @@ export class MinimapCalculateSvgScaleAndViewBoxExecution
   }
 
   public handle(request: MinimapCalculateSvgScaleAndViewBoxRequest): IFMinimapScaleAndViewBox {
+    if(!this._fFlow) {
+      return { scale: 1, viewBox: RectExtensions.initialize(0, 0, 0, 0) };
+    }
+
     const nodesRect = this._getScaledNodesBoundingBox(request.minSize);
     const minimapRect = this._getMinimapRect(request.element);
     const scale = this._calculateViewScale(nodesRect, minimapRect);

diff --git a/...w/src/f-minimap/domain/minimap-calculate-view-box/minimap-calculate-view-box.execution.ts b/...w/src/f-minimap/domain/minimap-calculate-view-box/minimap-calculate-view-box.execution.ts
@@ -21,6 +21,9 @@ export class MinimapCalculateViewBoxExecution implements IExecution<MinimapCalcu
   }
 
   public handle(request: MinimapCalculateViewBoxRequest): IRect {
+    if(!this._fFlow || !this._fCanvas) {
+      return RectExtensions.initialize();
+    }
     return this._getRectForMinimapView();
   }