Added load_sexes and expanded load_problem to support it
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foggalong
commented
Jul 25, 2024
| @@ -149,7 +149,7 @@ def load_sparse_symmetric_matrix(filename: str, dimension: int, nnz: int, | |||
| def load_sexes(filename: str, dimension: int) -> tuple[ | |||
| npt.NDArray[np.unsignedinteger], | |||
| npt.NDArray[np.unsignedinteger], | |||
| npt.NDArray[np.str] | |||
| npt.NDArray[np.str_] | |||
There was a problem hiding this comment.
This is specifically only a problem in versions of NumPy released after the one packaged with my Ubuntu which is why I didn't catch this locally 🤦♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
load_sexesto fix #18. The loaderload_problemuses the standard variable names used throughout the rest of the module and is more robust (onlysigma_filenameandmu_filenameare required, everything else is optional).