fix: correct order of in which response status and headers are written #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matteo-cristino
commented
Oct 23, 2024
matteo-cristino
commented
- fix: add missing const declaration
- chore: cleanup some unused vars and add types
- fix: correct order of in which response status and headers are written
- test: use of http_headers and success_code metadata together
puria
approved these changes
Oct 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 24, 2024
## [1.39.2](v1.39.1...v1.39.2) (2024-10-24) ### Bug Fixes * correct order of in which response status and headers are written ([#381](#381)) ([80e6f18](80e6f18))
|
🎉 This PR is included in version 1.39.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.