Fix victory-native/victory-zoom-container clipping bug #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue summary:
Previously, victory-native/victory-zoom-container spread the result of
`useVictoryZoomContainer` into `VictoryContainer`
```ts
const props = useVictoryZoomContainer(...)
return <VictoryContainer {...props} />;
```
Where the return type of `useVictoryZoomContainer` is
```
{
props: VictoryZoomContainerMutatedProps;
children: React.ReactElement[];
}
```
Because `VictoryContainer` received the entire `props` object as a prop, instead of spreading its
properties, values such as `width` and `height` were `undefined` - leading to the viewbox for the svg
element to render as `<svg viewBox="0 0 undefined undefined" ...>` thus clipping the rendered chart.
Solution:
Destructure the props/children result from `useVictoryContainer` and pass correctly to
`VictoryContainer`j
🦋 Changeset detectedLatest commit: f3e26d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djm158
changed the title
zibs
approved these changes
Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3022
Issue summary:
Previously, victory-native/victory-zoom-container spread the result of
useVictoryZoomContainerintoVictoryContainerWhere the return type of
useVictoryZoomContainerisBecause
VictoryContainerreceived the entirepropsobject as a prop, instead of spreading its properties, values such aswidthandheightwereundefined- leading to the svg element to render with undefined values in itsviewBox, e.g.thus clipping the rendered chart.
Solution:
Destructure the props/children result from
useVictoryContainerand pass correctly toVictoryContainerAdditional changes:
to the demo/rn project to enable web browser debugging.
pnpminstead ofyarnand includebuild --watchstep for improved debuggingType of Change
How Has This Been Tested?
Ran rn/demo project, added
victory-zoom-containerto confirm before/after changes visually.Screenshots
Before
After
Checklist: (Feel free to delete this section upon completion)